[18.0][FIX] account_invoice_margin: Remove product_cost_security.group_product_edit_cost from tests#266
Open
Andrii9090-tecnativa wants to merge 1 commit intoOCA:18.0from
Open
Conversation
Contributor
|
Hi @sergio-teruel, |
OCA-git-bot
added
series:18.0
mod:account_invoice_margin
…uct_edit_cost from tests
Andrii9090-tecnativa
force-pushed
the
18.0-fix-account_invoice_margin
branch
from
e24608d to
2995302
Compare
pedrobaeza
approved these changes
May 7, 2026
sergio-teruel
suggested changes
May 7, 2026
Contributor
There was a problem hiding this comment.
You are writing standard_price with sudo(), which bypasses the field access checks.
This PR fixes the issue:
OCA/product-attribute#2254
| ) | ||
| cls.product_a.lst_price = 200 | ||
| cls.product_a.standard_price = 100 | ||
| cls.product_a.sudo().write({"standard_price": 100}) |
Contributor
There was a problem hiding this comment.
If the other PR from @sergio-teruel is merged, the sudo can be removed. However, I think the groups also need to be removed because there is no explicit dependency here.
Author
|
@sergio-teruel It is only needed to change This module does not depend on product_cost_security, so we cannot use its XML ID in the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, the test fails.
account_invoice_margindoes not depend onproduct_cost_security@pedrobaeza can you review please.
@Tecnativa